ILProj + Signing with open key is broken

[ericstj]

ILAsm doesn't support full signing. It doesn't look like it will in the near future: https://github.com/dotnet/coreclr/issues/22862#issuecomment-467591230

To deal with this Arcade should have a copy of the open.snk that only contains the public key and define a combination of property values that can be used in the ilproj case so that we delay-sign.

[markwilkie]

Thoughts @tmat ?

[tmat]

Are we using ILProj to produce shipping binaries?

[ericstj]

Yes.

• https://github.com/dotnet/corefx/blob/master/src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj
• https://devdiv.visualstudio.com/DevDiv/_git/DotNet-Trusted?path=%2Fsrc%2FAccessibility%2Fsrc%2FAccessibility.ilproj&version=GBmaster

Both of those cases happen to use a different key so we don't hit this issue, but I noticed it with a test asset and wanted to raise it for completeness.

FWIW the test wouldn't even ever need to fully-sign itself, but it was defaulting the open key which CoreCLR ILASM was rejecting.

[ericstj]

If you're interested, Accessibility is a PIA and we build it this way because we don't have TLBImp for .netcore. It can't be defined in C# because it contains named indexers.

Unsafe does things in the IL that can't be done in C# because they are, well, unsafe.

[tmat]

It can't be defined in C# because it contains named indexers.

Can it be built in VB?

[tmat]

I think it's ok to have the issue raised, but let's implement it only when it's actually needed.

[ericstj]

WriteMetadataConstant

Possibly, but I don't expect folks would prefer that. Regardless I don't want to dig up those issues here.

I think it's ok to have the issue raised, but let's implement it only when it's actually needed.

That's fair. I don't expect many folks will want to both use ILProj and need to sign with the Open key.

[tmat]

Folks prefer to read IL over VB :-o?

[ericstj]

The IL is generated from the TLB then checked in, which is more reliable than a human trying to translate that to VB.

[tmat]

I see. Makes sense.