System.SR.vb(20,1): error BC30012 : '#If' block must end with a matching '#End If'

[RussKie]

• Is this issue blocking: yes
• Is this issue causing unreasonable pain: yes

The latest update from Arcade (dotnet/winforms#2624) fails Windows Forms builds with a peculiar error:

C:\Development\winforms\artifacts\obj\Microsoft.VisualBasic.Forms\Debug\netcoreapp5.0\System.SR.vb(21,9): 
error BC32035: Attribute specifier is not a complete statement. Use a line continuation to apply the attribute to the following statement. [C:\Development\winforms\src\Microsoft.VisualBasic.Forms\src\Microsoft.VisualBasic.Forms.vbproj]
C:\Development\winforms\artifacts\obj\Microsoft.VisualBasic.Forms\Debug\netcoreapp5.0\System.SR.vb(20,1): 
error BC30012: '#If' block must end with a matching '#End If'. [C:\Development\winforms\src\Microsoft.VisualBasic.Forms\src\Microsoft.VisualBasic.Forms.vbproj]

Here's the generated file: System.SR.vb
The offending snippet:

        Friend Shared Property Culture As Global.System.Globalization.CultureInfo
#If Not NET20 Then
        <Global.System.Runtime.CompilerServices.MethodImpl(Global.System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)>
#End If
        Friend Shared Function GetResourceString(ByVal resourceKey As String, Optional ByVal defaultValue As String = Nothing) As String
            Return ResourceManager.GetString(resourceKey, Culture)
        End Function
        ''' <summary>File not found.</summary>
        Friend Shared ReadOnly Property [ID53] As String
          Get
            Return GetResourceString("ID53")
          End Get
        End Property

Before the update there were no conditionals present, e.g.:

        Friend Shared Property Culture As Global.System.Globalization.CultureInfo

        <Global.System.Runtime.CompilerServices.MethodImpl(Global.System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)>
        Friend Shared Function GetResourceString(ByVal resourceKey As String, Optional ByVal defaultValue As String = Nothing) As String
            Return ResourceManager.GetString(resourceKey, Culture)
        End Function
        ''' <summary>File not found.</summary>
        Friend Shared ReadOnly Property ID53 As String
          Get
            Return GetResourceString("ID53")
          End Get
        End Property

[RussKie]

/cc: @KlausLoeffelmann

I think this came from #2208.

@tmat any suggestions here?

[tmat]

Oops. Fixing.

[tmat]

I did not realize VB does not support #if def around custom attributes :-|

[RussKie]

I did not realize VB does not support #if def around custom attributes :-|

It is not that it doesn't support it, it is that the wrapping it different to what c# supports.

https://docs.microsoft.com/en-us/dotnet/visual-basic/language-reference/directives/if-then-else-directives

[tmat]

Yeah, you need to repeat the whole signature. It doesn't really matter, we don't have any projects that build against NET20 in VB. So this is not really needed.