Skip to content

[release/6.0] Allow file protocol in source-build Git clones #12298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 2 commits into from
Jan 23, 2023
Merged

[release/6.0] Allow file protocol in source-build Git clones #12298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd50b8
Allow file protocol during source-build clone.
crummel Jan 23, 2023
b95d25c
Address code review comment.
crummel Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/git-clone-to-dir.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,14 @@ fi
# * '--no-local' allows a shallow clone from a git dir on the same filesystem. This means the
# clone will not use hard links and takes up more space. However, since we're doing a shallow
# clone anyway, the difference is probably not significant. (This has not been measured.)
git clone --depth=1 --no-local --no-checkout "$sourceDir" "$destDir"
# * '-c protocol.file.allow=alwyas allows cloning from the local filesystem even on newer versions
# of git which have disabled this for security reasons.
git clone -c protocol.file.allow=always --depth=1 --no-local --no-checkout "$sourceDir" "$destDir"

# Put the 'shallow' file back so operations on the outer Git repo continue to work normally.
printf "%s" "$shallowContent" > "$shallowFile"
else
git clone --no-checkout "$sourceDir" "$destDir"
git clone -c protocol.file.allow=always --no-checkout "$sourceDir" "$destDir"
fi

(
Expand Down