Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Feb 17, 2023

Introduce targeting properties Targeting implementation of https://github.com/dotnet/arcade/pull/11903/files. Adds three properties to allow repos to defer some/all of their target framework maintenance to arcade. Arcade already had a file like this for its own purposes. I've removed that and hoisted arcade's targeting property into its Directory.Build.props.

This is a backport to 7.0 so that source-build components using older arcades (e.g. if they target VS) can utilize the properties and allow source build to transparently set the TFM.

To double check:

@mmitche mmitche changed the title Introduce targeting properties (#12161) [release/7.0] Introduce targeting properties Feb 17, 2023
* Introduce targeting properties
Targeting implementation of https://github.com/dotnet/arcade/pull/11903/files.
Adds three properties to allow repos to defer some/all of their target framework maintenance to arcade.
Arcade already had a file like this for its own purposes. I've removed that and hoisted arcade's targeting property into its Directory.Build.props.
@mmitche mmitche force-pushed the back-port-targeting-props branch from d6446a0 to 9b854c8 Compare February 17, 2023 22:39
@mmitche
Copy link
Member Author

mmitche commented Feb 17, 2023

@MichaelSimons

@mmitche mmitche requested review from a team and rainersigwald February 17, 2023 22:40
@mmitche mmitche enabled auto-merge (squash) February 17, 2023 23:14
@mmitche mmitche merged commit 555a00b into dotnet:release/7.0 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants