Use DOTNET_GLOBAL_INSTALL_DIR to specify where the SDKs will be installed#16686
Merged
Use DOTNET_GLOBAL_INSTALL_DIR to specify where the SDKs will be installed#16686
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Arcade’s common bootstrap scripts to support installing (or locating) the required .NET SDK in a caller-specified “global” directory via DOTNET_GLOBAL_INSTALL_DIR, addressing scenarios where global.json includes additional runtimes.
Changes:
- Add
DOTNET_GLOBAL_INSTALL_DIRsupport as the preferred install root when the scripts would otherwise fall back to repo-local.dotnet. - Keep existing behavior of using
DOTNET_INSTALL_DIRonly whenglobal.jsondoes not specify additional runtimes and the required SDK version is present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/tools.sh | Uses DOTNET_GLOBAL_INSTALL_DIR as the dotnet install root when falling back from DOTNET_INSTALL_DIR / repo-local install logic. |
| eng/common/tools.ps1 | Mirrors the same DOTNET_GLOBAL_INSTALL_DIR-based install root selection in PowerShell. |
Member
|
@AndriySvyryd What's the difference between this and using DOTNET_INSTALL_DIR? |
Member
Author
|
@mmitche DOTNET_INSTALL_DIR is only used for lookup, DOTNET_GLOBAL_INSTALL_DIR also specifies where it will be installed |
mmitche
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will also be used for finding the SDKs if DOTNET_INSTALL_DIR is not set
Fixes #14283
Part of #1293
Validated both scripts manually