[main] Source code updates from dotnet/dotnet#16726
Merged
ViktorHofer merged 14 commits intomainfrom Apr 23, 2026
Merged
Conversation
Contributor
Author
|
Caution 🚨 Action Required — Conflict detectedA conflict was detected when trying to update this PR with changes from build The conflicts in the following files need to be manually resolved:
ℹ️ To resolve the conflicts, please follow these steps:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/dotnet/compare/36afe73557f5f93cd7bc827cb644a3ff018eca0b..36afe73557f5f93cd7bc827cb644a3ff018eca0b From: dotnet/dotnet@36afe73 To: dotnet/dotnet@36afe73 The following files had conflicts that were resolved by a user: - src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props
ViktorHofer
reviewed
Apr 20, 2026
ViktorHofer
reviewed
Apr 20, 2026
ViktorHofer
previously approved these changes
Apr 20, 2026
No dependency updates to commit [[ commit created by automation ]]
ViktorHofer
previously approved these changes
Apr 20, 2026
…s://github.com/dotnet/arcade into darc-main-b46622d4-f860-4171-9113-5c232204d1f3
premun
previously approved these changes
Apr 20, 2026
This reverts commit 37632b2.
premun
previously approved these changes
Apr 20, 2026
premun
approved these changes
Apr 21, 2026
premun
previously approved these changes
Apr 22, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RunWixTool redirects stdout/stderr but never reads the streams. When the child process (wix.exe) produces output exceeding the ~4KB pipe buffer, the write blocks and WaitForExit() deadlocks. WiX v6 (6.0.3) produces ~18KB of output on error, triggering this latent bug that was hidden with WiX v5's smaller output. Fix: read both streams before WaitForExit() and log the output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The WiX v5->v6 upgrade means the bundled extension DLLs in the test wixpack resources (WixToolset.Util.wixext.dll, WixToolset.UI.wixext.dll, WixToolset.BootstrapperApplications.wixext.dll, WixToolset.Dependency.wixext.dll) need to reference WixToolset.Extensibility v6.0.0.0 instead of v5.0.0.0. Without this, WiX v6's wix.exe fails with WIX0144 when loading the v5 extensions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
cc @joeloff for the last two commits that I pushed. Copilot found the hand and test failures and fixed them. |
wtgodbe
approved these changes
Apr 23, 2026
Member
|
Yaaay, finally |
Member
|
It looks like this messed up a bunch of the templates and broke the official build...it looks like it reverted the v4 publishing update reverting. |
Member
|
@mmitche I think it's this: dotnet/arcade-services#6195 We will prioritize it |
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Associated changes in source repos
Diff the source with this PR branch