Skip to content

[main] Source code updates from dotnet/dotnet#16726

Merged
ViktorHofer merged 14 commits intomainfrom
darc-main-b46622d4-f860-4171-9113-5c232204d1f3
Apr 23, 2026
Merged

[main] Source code updates from dotnet/dotnet#16726
ViktorHofer merged 14 commits intomainfrom
darc-main-b46622d4-f860-4171-9113-5c232204d1f3

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro Bot commented Apr 20, 2026

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Associated changes in source repos

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/dotnet:ab01524bbb2ef1eea0ffaef161b3ef5686e8f256..https://github.com/dotnet/arcade:darc-main-b46622d4-f860-4171-9113-5c232204d1f3

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

Caution

🚨 Action Required — Conflict detected

A conflict was detected when trying to update this PR with changes from build 311032 of https://github.com/dotnet/dotnet/tree/36afe73557f5f93cd7bc827cb644a3ff018eca0b.

The conflicts in the following files need to be manually resolved:

  • src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props
    🔍 View file in dotnet/arcade vs VMR

ℹ️ To resolve the conflicts, please follow these steps:

  1. Clone the current repository
    git clone https://github.com/dotnet/arcade
    cd arcade
  2. Make sure your darc is up-to-date
    (version 1.1.0-beta.26214.2 or higher)
    # Linux / MacOS
    ./eng/common/darc-init.sh
    # or on Windows
    .\eng\common\darc-init.ps1
  3. Run from repo's git clone and follow the instructions provided by the command to stage the conflict locally
    darc vmr resolve-conflict --subscription b472297a-0d16-41ea-91af-ee5ed4325178
    This should apply the build 311032 with sources from 36afe73
  4. Resolve the conflicts, commit & push the changes
  5. Once pushed, the Codeflow verification check will turn green.
    If not, a new build might have flown into the PR and you might need to run the command above again.

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

Diff: https://github.com/dotnet/dotnet/compare/36afe73557f5f93cd7bc827cb644a3ff018eca0b..36afe73557f5f93cd7bc827cb644a3ff018eca0b

From: dotnet/dotnet@36afe73
To: dotnet/dotnet@36afe73

The following files had conflicts that were resolved by a user:

- src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props
@ViktorHofer ViktorHofer requested a review from a team as a code owner April 20, 2026 10:44
Comment thread eng/common/sdk-task.ps1
Comment thread eng/Version.Details.props
ViktorHofer
ViktorHofer previously approved these changes Apr 20, 2026
No dependency updates to commit
[[ commit created by automation ]]
ViktorHofer
ViktorHofer previously approved these changes Apr 20, 2026
premun
premun previously approved these changes Apr 20, 2026
This reverts commit 37632b2.
premun
premun previously approved these changes Apr 20, 2026
@ViktorHofer ViktorHofer enabled auto-merge (squash) April 20, 2026 15:41
premun
premun previously approved these changes Apr 22, 2026
@premun
Copy link
Copy Markdown
Member

premun commented Apr 23, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

RunWixTool redirects stdout/stderr but never reads the streams.
When the child process (wix.exe) produces output exceeding the
~4KB pipe buffer, the write blocks and WaitForExit() deadlocks.

WiX v6 (6.0.3) produces ~18KB of output on error, triggering this
latent bug that was hidden with WiX v5's smaller output.

Fix: read both streams before WaitForExit() and log the output.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The WiX v5->v6 upgrade means the bundled extension DLLs in the test
wixpack resources (WixToolset.Util.wixext.dll, WixToolset.UI.wixext.dll,
WixToolset.BootstrapperApplications.wixext.dll, WixToolset.Dependency.wixext.dll)
need to reference WixToolset.Extensibility v6.0.0.0 instead of v5.0.0.0.
Without this, WiX v6's wix.exe fails with WIX0144 when loading the v5 extensions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ViktorHofer
Copy link
Copy Markdown
Member

cc @joeloff for the last two commits that I pushed. Copilot found the hand and test failures and fixed them.

@ViktorHofer ViktorHofer merged commit 0bae2b2 into main Apr 23, 2026
13 of 15 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-b46622d4-f860-4171-9113-5c232204d1f3 branch April 23, 2026 18:28
@ViktorHofer
Copy link
Copy Markdown
Member

Yaaay, finally

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Apr 23, 2026

It looks like this messed up a bunch of the templates and broke the official build...it looks like it reverted the v4 publishing update reverting.

@premun
Copy link
Copy Markdown
Member

premun commented Apr 24, 2026

@mmitche I think it's this: dotnet/arcade-services#6195

We will prioritize it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants