Add .cab to default FileExtensionSignInfo for signing#16742
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Apr 24, 2026
Merged
Add .cab to default FileExtensionSignInfo for signing#16742jkoritzinsky merged 1 commit intodotnet:mainfrom
jkoritzinsky merged 1 commit intodotnet:mainfrom
Conversation
Cabinet (.cab) files inside MSI containers are signable via Authenticode but were not included in the Arcade SDK's default FileExtensionSignInfo. This caused the SignTool to skip .cab files in all repos that produce MSIs (runtime, emsdk, macios, aspnetcore, SDK), resulting in unsigned cabs flagged by the VS signing scan. Adding .cab alongside .dll/.exe/.mibc/.msi ensures all Arcade-based repos get correct cab signing by default, rather than each repo needing to add it individually in eng/Signing.props. Tracking: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2911494
jesuszarate
added a commit
to jesuszarate/runtime
that referenced
this pull request
Apr 23, 2026
The VS signing scan requires every signable file to carry its own signature. The Mono workload packs contain 198 unsigned .js files (browser-wasm runtime scripts) that are customer-modifiable. For .js files: keep CertificateName=None (same as dotnet/emsdk#1671) because these are customer-modifiable runtime files. Instead, generate a .cat catalog file covering all .js files, signed via FileExtensionSignInfo for .cat. The GenerateCatalogFiles target runs after AddMonoRuntimeFiles on Windows browser-wasm builds. For .cab files: moved to dotnet/arcade (dotnet/arcade#16742) so all Arcade-based repos get correct cab signing by default. Tracking: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2911494
jkoritzinsky
approved these changes
Apr 23, 2026
Contributor
Author
|
@jkoritzinsky - Are you able to merge the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cabinet (.cab) files inside MSI containers are signable via Authenticode but are not included in the Arcade SDK's default
FileExtensionSignInfoentries. This causes the SignTool to skip .cab files in all Arcade-based repos that produce MSIs, resulting in unsigned cabs flagged by the VS signing compliance scan.This affects multiple repos: dotnet/runtime, dotnet/emsdk, dotnet/macios, dotnet/aspnetcore, and potentially the SDK — each producing WiX MSIs with embedded cabs that go unsigned.
Fix
Add
.cabto the existing.dll;.exe;.mibc;.msiline insrc/Microsoft.DotNet.Arcade.Sdk/toolset/Sign.props:This ensures all Arcade-based repos get correct cab signing by default. Repos that set
UseDotNetCertificate=truewill automatically useMicrosoftDotNet500instead.Context
Suggested by @jkoritzinsky in dotnet/runtime#127242 — rather than adding
.cabper-repo in eacheng/Signing.props, centralizing it in Arcade fixes all repos at once and covers future repos automatically.Tracking
VS signing compliance: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2911494