Skip to content

Install runtimes to DOTNET_GLOBAL_INSTALL_DIR when set #16764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 3 commits into from
Apr 29, 2026
+16 −3
Merged

Install runtimes to DOTNET_GLOBAL_INSTALL_DIR when set #16764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2a58ec
Fix runtime install dir to respect DOTNET_GLOBAL_INSTALL_DIR
Copilot Apr 28, 2026
e8a7a61
Use DOTNET_GLOBAL_INSTALL_DIR instead of DOTNET_INSTALL_DIR for runti…
Copilot Apr 28, 2026
0a5c28f
Respect DOTNET_GLOBAL_INSTALL_DIR in eng/common/dotnet-install wrappers
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eng/common/dotnet-install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ Param(

. $PSScriptRoot\tools.ps1

$dotnetRoot = Join-Path $RepoRoot '.dotnet'
if (-not [string]::IsNullOrEmpty($env:DOTNET_GLOBAL_INSTALL_DIR)) {
$dotnetRoot = $env:DOTNET_GLOBAL_INSTALL_DIR
} else {
$dotnetRoot = Join-Path $RepoRoot '.dotnet'
}

$installdir = $dotnetRoot
try {
Expand Down
6 changes: 5 additions & 1 deletion eng/common/dotnet-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ case $cpuname in
;;
esac

dotnetRoot="${repo_root}.dotnet"
if [[ -n "${DOTNET_GLOBAL_INSTALL_DIR:-}" ]]; then
dotnetRoot="$DOTNET_GLOBAL_INSTALL_DIR"
else
dotnetRoot="${repo_root}.dotnet"
fi
if [[ $architecture != "" ]] && [[ $architecture != $buildarch ]]; then
dotnetRoot="$dotnetRoot/$architecture"
fi
Expand Down
7 changes: 6 additions & 1 deletion src/Microsoft.DotNet.Arcade.Sdk/toolset/InstallDotNetCore.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,15 @@

<Exec Condition="'$(OS)' != 'Windows_NT'" Command="chmod +x &quot;$(_DotNetInstallScript)&quot;" />

<PropertyGroup>
<_DotNetPath Condition="'$(DOTNET_GLOBAL_INSTALL_DIR)' != ''">$(DOTNET_GLOBAL_INSTALL_DIR)</_DotNetPath>
<_DotNetPath Condition="'$(_DotNetPath)' == ''">$(RepoRoot).dotnet</_DotNetPath>
</PropertyGroup>

<InstallDotNetCore
VersionsPropsPath="$(RepositoryEngineeringDir)Versions.props"
GlobalJsonPath="$(RepoRoot)global.json"
DotNetPath ="$(RepoRoot).dotnet"
DotNetPath="$(_DotNetPath)"
Comment thread
AndriySvyryd marked this conversation as resolved.
DotNetInstallScript="$(_DotNetInstallScript)"
Platform="$(Platform)"
RuntimeSourceFeed="$(DotNetRuntimeSourceFeed)"
Expand Down
Loading