Skip to content

Revert "Remove Microsoft.DotNet.XUnitAssert (#16734)"#16769

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/revert-pr-16734
Closed

Revert "Remove Microsoft.DotNet.XUnitAssert (#16734)"#16769
Copilot wants to merge 1 commit intomainfrom
copilot/revert-pr-16734

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

Reverts #16734, which removed the Microsoft.DotNet.XUnitAssert AOT-compatible xunit assert fork in favor of the official xunit.v3.assert.aot package.

  • Restores src/Microsoft.DotNet.XUnitAssert/ (source, tests, README)
  • Restores Microsoft.DotNet.XUnitAssert project entry in Arcade.slnx
  • Reverts XUnit.targets back to $(UseDotNetXUnitAssert) / Microsoft.DotNet.XUnitAssert package references
  • Restores XUnitAssert update instructions in Documentation/update-xunit.md
  • Resolves conflicts from follow-up cleanup commit Remove leftover DotNetXUnitAssert references #16754 (same files) by restoring the pre-Remove Microsoft.DotNet.XUnitAssert #16734 state

To double check:

This reverts commit 8dcd57d.

Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
@Youssef1313
Copy link
Copy Markdown
Member

Youssef1313 commented Apr 30, 2026

I think this might not be very needed after #16763 is now merged? Just that runtime will have to use UseXUnitAOTAssert where needed (in the places where it previously have used DotNetXUnitAssert)

@agocke agocke closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants