Skip to content

Add 5 hour expiration when checking if file is up to date #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 1, 2019
Merged

Add 5 hour expiration when checking if file is up to date #2147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Microsoft.DotNet.Helix/JobSender/Payloads/DirectoryPayload.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public DirectoryPayload(string directory, string archiveEntryPrefix)
}
}

private const int CacheExpiryHours = 5;
public DirectoryInfo DirectoryInfo { get; }

public string NormalizedDirectoryPath => Helpers.RemoveTrailingSlash(DirectoryInfo.FullName);
Expand Down Expand Up @@ -104,6 +105,11 @@ private async Task<string> DoUploadAsync(IBlobContainer payloadContainer, Action

private bool IsUpToDate(FileInfo alreadyUploadedFile)
{
if (alreadyUploadedFile.LastWriteTimeUtc.AddHours(CacheExpiryHours) < DateTime.UtcNow)
{
return false;
}

var newestFileWriteTime = DirectoryInfo.EnumerateFiles("*", SearchOption.AllDirectories)
.Select(file => file.LastWriteTimeUtc)
.Max();
Expand Down