Improve usability of APICompat#2672
Merged
ericstj merged 2 commits intodotnet:masterfrom May 7, 2019
Merged
Conversation
Member
Author
|
CoreFx changes: dotnet/corefx#37375 |
3 tasks
Member
Author
|
Ok, this is ready to go now. CoreFx is passing with my changes. Can I please get a review? @wtgodbe @safern @ViktorHofer |
wtgodbe
reviewed
May 3, 2019
wtgodbe
reviewed
May 3, 2019
wtgodbe
approved these changes
May 3, 2019
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
LGTM outside of the 2 comments
ViktorHofer
reviewed
May 3, 2019
ViktorHofer
reviewed
May 3, 2019
ViktorHofer
reviewed
May 3, 2019
ViktorHofer
approved these changes
May 3, 2019
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
I don't understand all the changes that you are making in the targets file but I trust you.
Member
Author
|
Holding off on merge until @ViktorHofer gets the Arcade updates in (I don't want to break him any worse). |
Member
Author
|
Now waiting on @Anipik's changes to flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the last couple months I've helped various teams on-board API compat and hit some common problems.
I wanted to address those and also write a doc.
I plan to add a "case study" section to the doc that illustrates one solution that uses this, but I'd like to wait until we iron out all the details in that solution.
Fixes #2297, #2289