Allow pass-thru arguments in eng\common\build.sh#2696
Merged
wtgodbe merged 1 commit intodotnet:masterfrom May 6, 2019
Merged
Conversation
ViktorHofer
approved these changes
May 6, 2019
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
I'm ok with the change as it adds consistency between the build scripts but would recommend to wait for another review from one of the arcade owners.
Member
|
cc/ @alexperovich |
alexperovich
approved these changes
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eng\common\build.ps1passes through all unrecognized arguments to msbuild:arcade/eng/common/build.ps1
Line 24 in 6a34948
eng\common\build.sh. This will unblock my PR in Standard (without it I can't passwarnAsMessageto msbuild): dotnet/standard#1173@chcosta @riarenas @jcagme @tmat @ViktorHofer PTAL