-Raw required to support ConvertFrom-Json on Powershell 3.0#42
Merged
Conversation
natemcmaster
approved these changes
Mar 2, 2018
Member
Author
Contributor
|
That makes sense. Maybe we should add #requires -version 5https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_requires |
Member
Author
|
What would that do to CI, where we may not have as much control over the version? |
Contributor
|
A better error that would look like this: |
Member
Author
|
I agree that would be a better error. Sounds like something that should be considered once we can be more proscriptive about the powershell dependency in CI or official build machines. I'll file an issue to track this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing CI