Use common arcade props instead of repo local ones#4254
Merged
ViktorHofer merged 1 commit intodotnet:masterfrom Oct 31, 2019
Merged
Use common arcade props instead of repo local ones#4254ViktorHofer merged 1 commit intodotnet:masterfrom
ViktorHofer merged 1 commit intodotnet:masterfrom
Conversation
akoeplinger
approved these changes
Oct 31, 2019
Member
Author
|
/azp run arcade-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dagood
reviewed
Oct 31, 2019
Member
dagood
left a comment
dagood
left a comment
There was a problem hiding this comment.
LGTM, thanks. I'll keep an eye on the WindowsDesktop arcade PR to make sure it goes through there. (It should because both properties should be defined the same way.)
Member
Author
|
Thanks. I checked windowsdesktop before I merged, the change should be safe as it imports Arcade. If we care much we could do the same change there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.