Support nuget static graph eval in Build.props

[ViktorHofer]

This allows to set RestoreUseStaticGraphEvaluation in Build.props so that projects invoked via -projects can use the new nuget static graph evaluation restore.

[safern]

We were not passing this property to _IsProjectRestoreSupported target, will it change anything?

[ViktorHofer]

That target doesn't run for static graph evaluation it doesn't need to be passed in.

[tmat]

What's are the pros/cons of setting RestoreUseStaticGraphEvaluation to true? Would setting it by default for all repos be good/bad?

[ViktorHofer]

That would be SUPER bad. That mode doesn't support all feature that the current nuget restore supports. Ie hook targets are removed, item property conversion doesn't work, etc. We should move the main repos over to use it (as restore and no-op restore are faster) but this definitely needs to continue being an opt-in for some time.

[tmat]

Ok, then I suggest we file an issue in Arcade that tracks the progress and link if from here. Let's mention the requirements there, so that repo owners have some info based on which they could decide to enable or not. Also I'd name the property name like so: RestoreUsingStaticGraphEvaluation

[ViktorHofer]

Ok, then I suggest we file an issue in Arcade that tracks the progress and link if from here.

Sounds good but I would prefer doing this in a follow-up issue. I will be OOF rest of the week and I want to get this in for dotnet/runtime to be able to use the switch, ie for projects passed in via the -projects switch.

Also I'd name the property name like so: RestoreUsingStaticGraphEvaluation

I'm hesitant renaming the switch to something else than the nuget property's name. That would easily confuse consumers.

[markwilkie]

This feels like something that should be documented in Arcade as well. Perhaps in the SDK doc?

[tmat]

I'm hesitant renaming the switch to something else than the nuget property's name. That would easily confuse consumers.

Makes sense.

[tmat]

Sounds good but I would prefer doing this in a follow-up issue.

Sure.

[safern]

Merging as @ViktorHofer is OOF and builds are green and seems like @tmat agreed on his statements above, he can follow up for the issue and docs once he's back.