Skip to content

Put manifest generation behind a switch#5259

Merged
chcosta merged 2 commits into
dotnet:masterfrom
chcosta:manifest-switch
Apr 14, 2020
Merged

Put manifest generation behind a switch#5259
chcosta merged 2 commits into
dotnet:masterfrom
chcosta:manifest-switch

Conversation

@chcosta
Copy link
Copy Markdown
Member

@chcosta chcosta commented Apr 14, 2020

Fixes #5255 dotnet/arcade-validation#1409

Puts manifest generation behind a switch (enabled in Arcade), so that I can investigate Linux failures further.

Validated with:

@chcosta chcosta requested review from a user and JohnTortugo April 14, 2020 18:26
Copy link
Copy Markdown
Contributor

@JohnTortugo JohnTortugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chcosta
Copy link
Copy Markdown
Member Author

chcosta commented Apr 14, 2020

WTF, CI is failing tests with

It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '2.1.0' was not found.
  - The following frameworks were found:
      3.1.1 at [/__w/1/s/.dotnet/shared/Microsoft.NETCore.App]

I don't see how my change could possibly be related. I'm looking... :(

@chcosta
Copy link
Copy Markdown
Member Author

chcosta commented Apr 14, 2020

Ok, I think I found it, this is me

@chcosta chcosta merged commit 5f64bc0 into dotnet:master Apr 14, 2020
@chcosta chcosta deleted the manifest-switch branch April 14, 2020 21:39
@tmat
Copy link
Copy Markdown
Member

tmat commented Apr 16, 2020

Assuming this is just a workaround and will be reverted?

@chcosta
Copy link
Copy Markdown
Member Author

chcosta commented Apr 16, 2020

Yes, already undone - #5267

@tmat
Copy link
Copy Markdown
Member

tmat commented Apr 16, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors loading GenerateAzureDevOpsBuildManifest in linux

3 participants