Fix manifest generation on Linux#5262
Merged
Merged
Conversation
|
Wow. Well at least you caught it. |
ghost
approved these changes
Apr 15, 2020
|
@chcosta would you mind creating a PR to arcade validation so that the build there passes the switch and we have coverage for this scenario? |
Member
Author
|
I'll revert the change to make this optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5255
Sadly, this was a simple matter of casing. I presume I was unable to get this to repro locally because I was using Docker for Windows with a local mounted filesystem which I then cloned into. :(
Validated with https://dev.azure.com/dnceng/public/_build/results?buildId=601047&view=results