Upgrade Arcade to a 5.0 SDK

[ViktorHofer]

Fixes #5394

To support the net5.0 TFM change we need to update the SDK for a newer NuGet.

[markwilkie]

This makes sense to me, but running it by @mmitche and @jaredpar as well as I might be missing something.

[ghost]

Should we move to the latest released SDK?
https://github.com/dotnet/arcade/blob/master/Documentation/Policy/ToolsetPolicy.md#net-sdk--managed-toolset

mentions staying on the latest released preview (which we also haven't done), but also mentions moving to a non-released one should come with approval from tactics.

[ViktorHofer]

We can downgrade to a officially released P2 or P3 build. Picked the latest nightly build as it includes some VSTest features that might be useful for #5347 (ie specifying a default filter in the .runsettings file, pointing to a custom dotnet host and not swallowing build output during VSTest).

[ViktorHofer]

@swaroop-sridhar can you please take a look at the .deps.json build failures? Looks related to dotnet/aspnetcore#21017 (comment). cc @dougbu

[dougbu]

I suppressed NU5118 warnings because figuring out the root cause was going to take too much time. An actual fix would be great.

[ViktorHofer]

ping @swaroop-sridhar

[mmitche]

This is sending warning bells that we may have attempted this before and decided against it. Maybe @jaredpar remembers?

[swaroop-sridhar]

ping @swaroop-sridhar

I posted a PR for the PublishDepsFilePath setting dotnet/sdk#11462
PublishDepsFilePath is also used by the packing targets, so it does seem related to the issue.

[ViktorHofer]

@swaroop-sridhar the failures are still the same with the new SDK.

[ViktorHofer]

The error goes away if I comment out all the PackageReferences used during the build.

[ViktorHofer]

Submitted a fix to the SDK: dotnet/sdk#11522

[ViktorHofer]

@markwilkie this should be ready now. Can we clarify if we are fine upgrading to a preview5 SDK? IMO it shouldn't be an issue.

[dougbu]

See also the breaks we hit in dotnet/razor#1692 (comment) and dotnet/aspnetcore#21017 (comment). Discussion about the second problem continues in my dotnet/sdk#11527 PR.

[dougbu]

Oops, forgot about incorrect NU5129 warnings I commented on at dotnet/aspnetcore#21017 (comment) and today at dotnet/aspnetcore#21017 (comment) with responses later from @rrelyea.

[dougbu]

For the dotnet/aspnetcore#21017 (comment) break, my dotnet/sdk#11527 PR is on hold for further discussion. Repos other than dotnet/aspnetcore that adjust .deps files may need to adjust as I did in dotnet/aspnetcore@3ef5452 i.e. run their rewrite target later or use $(IntermediateDepsFilePath) instead of $(PublishDepsFilePath).

[ViktorHofer]

@markwilkie I downgraded to the official preview3 released version which should be less controversial. I want to get this in as it blocks the build promotion.

[markwilkie]

Makes sense @ViktorHofer. If @mmitche, @Pilchie and @jaredpar are good with this, I am too. An email head's up to tactics is probably in order too, especially given the noise.

Adding @missymessa as we'll hopefully be able to promote today and it sounds like you need this in soon.

[Pilchie]

Yes, I'm good with this.

[ViktorHofer]

Approved by Tactics - merging.