Generate prebuilt report and include it in the intermediate nupkg (arcade-powered source-build)#6121
Merged
dagood merged 7 commits intodotnet:masterfrom Sep 4, 2020
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Microsoft.DotNet.SourceBuild.Tasks. This is separate fromMicrosoft.DotNet.Arcade.Sdkbecause the dependencies it takes on NuGet libraries are in danger of conflicting with what's loaded by Arcade already. See #6014. The tasks in this new package let us track prebuilts, for dotnet/source-build#1715.To use the tasks in
Microsoft.DotNet.SourceBuild.Tasks, we restore that package inTools.projif we're running source-build, and then use it from a new build stepAfterSourceBuild.proj. (Since we're relying onExecuterestoringTools.proj, we now need to add a build step rather than doing everything inBeforeTargets=Execute.)AfterSourceBuild.projonly runs if'$(ArcadeBuildFromSource)' == 'true', so I believe these changes will have no effect on existing infra.I also moved the intermediate nupkg generation from a
BeforeTargets="Execute"target toAfterSourceBuild.proj, so I could include the prebuilt report generated inAfterSourceBuild.projin the intermediate nupkg. This is for dotnet/source-build#1725.I included a test project for the new tasks. Currently there's only a tiny test to justify the project's existence. The tasks are simply copied from dotnet/source-build, so there isn't any significant test coverage yet. I want to make sure we have a test project ready so we don't have a barrier to entry to adding regression tests and such in the future.