Incorporate source-build TargetFramework update patch#6841
Merged
dagood merged 1 commit intodotnet:masterfrom Jan 29, 2021
Merged
Incorporate source-build TargetFramework update patch#6841dagood merged 1 commit intodotnet:masterfrom
dagood merged 1 commit intodotnet:masterfrom
Conversation
This was referenced Jan 26, 2021
Member
|
Seems fine, let's make sure it works with SourceBuild enabled then I'll sign off. |
MattGal
approved these changes
Jan 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6879
The initial arcade-powered source-build PR (#6837) introduced a
.patchfile to handle building fornet5.0rather thannetcoreapp2.1. This PR incorporates the patch into the source (as much as possible).Even though we're building for 6.0, dotnet/arcade still uses a 5.0.100 SDK to build, so this PR still targets
net5.0for now.https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/implementation-plan.md