Add option to prefer 64bit msbuild#7531
Conversation
2a4a6b9 to
3c54936
Compare
|
This fix, included in dotnet/aspnetcore#33497, built successfully in https://dev.azure.com/dnceng/public/_build/results?buildId=1189546&view=results. We seem to need this fix to build release/3.1 -- at least until we reach VS v16.9.7 or v16.10.0 (better if v16.10.2) in the regular VS2019 queues. |
|
@MattGal do I need to do anything special because this is targeting release/3.x❔ The change can't break anything but I'm unsure about servicing rules in this repo. |
rainersigwald
left a comment
There was a problem hiding this comment.
LGTM and I would think about going so far as to flip the default in Arcade 6; VS2022 will generally use 64-bit MSBuild so it'd be nice if Arcade was consistent. We'd still need an opt-out though for tasks that are 32-bit only but don't say so correctly.
|
Oops this is a protected branch and I can only push to 'main'. @mmitche or @MattGal please squish 'n merge Once that's done, I don't see a backport action in this repo yet. But |
We just removed that (the common scripts don't merge cleanly at all), so it will need to be backported to main. |
I'll get right on it. |
To double check:
I'm trying this out in dotnet/aspnetcore#33497. Starting this in parallel so I don't forget between now and dotnet/aspnetcore's next Arcade update for 3.1.x.
See also conversation in that PR about why this is worth having as an option.