-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Adopt Bedrock Client abstractions in SignalR client #10872
Copy link
Copy link
Closed
Labels
DoneThis issue has been fixedThis issue has been fixedarea-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsarea-signalrIncludes: SignalR clients and serversIncludes: SignalR clients and servers🥌 Bedrock
Milestone
Metadata
Metadata
Assignees
Labels
DoneThis issue has been fixedThis issue has been fixedarea-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsarea-signalrIncludes: SignalR clients and serversIncludes: SignalR clients and servers🥌 Bedrock
Type
Fields
Give feedbackNo fields configured for issues without a type.
Epic #10869
SignalR currently uses the "Bedrock" abstractions on the server side (
ConnectionContext, etc.) but has a custom client-side abstraction (IConnectionFactory). Bedrock has evolved to support a client-side abstraction now so SignalR should update to use it (since it would be a breaking change).The new client abstraction shape is:
Some elements to this:
IConnectionFactory(as above) somewhere (Connections.Abstractions? or a new library?)HttpEndpontsub-class ofSystem.Net.Endpoint(for use in theIConnectionFactory.ConnectAsyncmethod).TransferFormatin the constructor instead of in theConnectAsyncmethod?