Microsoft.Web.Xdt.Extensions shows up as a package dependency in Microsoft.AspNetCore.AzureAppServices.SiteExtension

[mmitche]

Microsoft.AspNetCore.AzureAppServices.SiteExtension has a package dependency on Microsoft.Web.Xdt.Extensions, even though the reference is listed as PrivateAssets="all"

[Pilchie]

@BrennanConroy - do you know what's up here?

[Pilchie]

Also @anurse since this is related to #20817

[dougbu]

This is likely a problem in eng/targets/ResolveReferences.targets. In particular, PrivateAssets="all" metadata seems to be lost, producing a package with an unintended ref to an internal project that isn't even packable. Putting this on our build board…

[BrennanConroy]

Fortunately this doesn't seem to affect consumption of the package.

[analogrelay]

Putting this on our build board

We should try to prioritize this. Let me know @dougbu if this isn't going to make it this "sprint" and we can look at what we can do. As @BrennanConroy says, it doesn't actually affect usage because Site Extension dependencies aren't even considered when Azure App Service installs them.

[dougbu]

Does this still happen now that we're using JoinItems in eng/ResolveReferences.targets❔ That only went in a few days ago.

[dougbu]

Or, do we need to port my JoinItems change to 'release/3.1' to fix this❔

[wtgodbe]

This reproed on a build of master at SHA 2743965 (5/4/20 at 8:39 AM)

[dougbu]

Ah, the problem is that we're trying to use PrivateAssets="all" in Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj. That should be ReferenceOutputAssembly="false" to work outside @(PackageReference) items.

Safest to include both metadata bits so the @(Reference) item works whichever the final item group it lands in.

[dougbu]

I can do this quickly if you're working elsewhere @wtgodbe. LMK