Big fall in Json, MVC plaintext, MVC Json

[benaadams]

Change set: dc08a60...d2db467 looks to be deps outside AspNetCore

@dougbu @sebastienros as you may understand what deps are related?

The MVC gain at end is changeset d2db467...1baeaaa

[sebastienros]

The bot got it and I am already investigating. Traces will follow, currently trying to pinpoint the change.

[sebastienros]

Better changeset containing the regression: dc08a60...88599a5

[benaadams]

Anyway to get the changeset for the Extension reference change? I assume the EF changes aren't relevant... or at least one hopes 😄

[sebastienros]

I can try to get that

[sebastienros]

In the meantime, from Citrine's diff:

[benaadams]

In the meantime, from Citrine's diff:

Not sure if that's a decrease in contention for SocketAsyncEngine? As this PR is in range of the previous runtime update "SocketAsyncEngine.Unix: improve performance of context lookup" dotnet/corefx#36358

@tmds @stephentoub

[sebastienros]

The negative needs to be read in the opposite, I compared the lowest to the baseline (higher)

Oh, so that might mean I should have looked at the positive changes, which in this case

[sebastienros]

Here is the diff for extensions:
dotnet/extensions@17cb526...0b1aa47

Which updated System.IO.Pipelines

[benaadams]

Libuv hit by same drop so unlikely to be the sockets change

Platform and mw plaintext seem uneffected so unlikely Pipelines; mvc middleware heavily effected

[sebastienros]

Any "pipelined" one I think

[sebastienros]

Has there there been any change related to the ThreadPool or Exceptions management?

[benaadams]

However mw json effected as is mvc json 🤔

[benaadams]

Any "pipelined" one I think

mw plaintext not being effected (neither non-pipelined or pipelined), but mvc plaintext being effected is the oddity (and then both forms of json being effected)