Log stdout to event log on failure to start process for ANCM out of process#10123
Merged
Conversation
Contributor
Author
|
This be green now 😄 |
Member
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
Should there be a test that verifies only the first 30kb of output is logged?
Contributor
Author
Yeah we should. Laziness on my part 🐋 |
Contributor
Author
|
🆙 📅 |
BrennanConroy
approved these changes
May 17, 2019
Contributor
Author
|
I would like to profile this before merging. I'm concerned that setting these to handles will have a perf impact if we are logging in a middleware. |
Contributor
Author
|
Verified locally, no performance regression when logging informational on localhost. I'll still like to do a second pass (and I'll add the accepted label eventually) after we merge this and it is available in the hosting bundle. I'm most concerned about performance on azure, so I'll make sure to verify it there. I'll merge once this is green. |
ghost
deleted the
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still thinking about how to simplify some event logs (kind of spammy right now). Will mark out of draft appropriately.
Fixes #10005