Revert "Remove CancelableEnumerator (#10099)"#10129
Merged
Merged
Conversation
This reverts commit d37b2ca.
mikaelm12
requested review from
BrennanConroy,
analogrelay and
halter73
as code owners
halter73
approved these changes
May 10, 2019
Contributor
Author
|
This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com. I've triaged the above build. I've created/commented on the following issue(s) |
ghost
deleted the
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be sure to dispose the cts registration.
And the actual fix here is to get rid of all of our CancelableEnumerable and use the now (hopefully) supported built in cancellation for
IAsyncEnumerable. Using the[EnumeratorCancellation]attribute to flow and combine tokens.