Remove build Java from E2E testing#11603
Closed
javiercn wants to merge 1 commit into
Closed
Conversation
BrennanConroy
added
area-infrastructure
Contributor
|
@aspnet/build could you guys sign off? Not having our tests run is really problematic |
dougbu
approved these changes
Jun 26, 2019
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Guess this will work. I worry about the experience for local users who want to run other e2e tests and don't have or want Java installed.
Suggest changing the EnforcePrerequisites error or the referenced readme to mention /p:SeleniumE2ETestsSupported=false or equivalent env variable.
JunTaoLuo
approved these changes
Jun 26, 2019
Contributor
JunTaoLuo
left a comment
JunTaoLuo
left a comment
There was a problem hiding this comment.
To unblock but this is not the ideal fix
javiercn
force-pushed
the
javiercn/remove-build-java
branch
from
ee755a5 to
e9d876a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See if this actually causes the build to fail.