Cleanup processes started by UseReactDevelopmentServer and UseAngularCliServer#17883
Conversation
AndriySvyryd
force-pushed
the
Issue11597
branch
4 times, most recently
from
c99927c to
6696063
Compare
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
As far as I can tell the actual code change here is good, but I believe the tests as-is are likely to be flaky. Should be in a much better place once that's resolved.
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="package.json"> |
There was a problem hiding this comment.
What's the behavior we get without this line?
There was a problem hiding this comment.
npm exits immediately
| } | ||
|
|
||
| private string GetCommand() | ||
| => RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "waitWindows" : "wait"; |
There was a problem hiding this comment.
What are we trying to accomplish with these? Get command is a bit nondescript. What are the criteria that these commands have to meet in order to work in this instance?
There was a problem hiding this comment.
The command must run indefinitely until the process is killed
AndriySvyryd
force-pushed
the
Issue11597
branch
4 times, most recently
from
e88ee60 to
33997d5
Compare
AndriySvyryd
force-pushed
the
Issue11597
branch
from
33997d5 to
4838467
Compare
analogrelay
added
area-mvc
|
@ryanbrandenburg are we waiting for more changes from @AndriySvyryd here? |
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
Awesome! I really like the diagnostic listener pattern, I might end up stealing that in some spots.
One small comment inclusion then I think we can call this good.
AndriySvyryd
force-pushed
the
Issue11597
branch
from
4838467 to
1ff648c
Compare
|
Hi @AndriySvyryd can you tell when this is gonna be published with the SDK ? |
|
Nightly builds should already have this. Preview1 will be out soon*. The RTM version will be out in November. |
|
Hi @AndriySvyryd, the related issue still can produce in dot net version 5.0.100. If I start debug using (not using IIS) Visual Studio (16.8.2), node process still open even I stopped the debug. But the crt+c will kill all the node process when you use dotnet run command using developer user command prompt. |
|
Hi @JSLGeeganage. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
7 participants
Fixes #11597