Skip to content

ClientCertificateMode now read from config#18759

Closed
kuns200 wants to merge 1 commit into
dotnet:masterfrom
kuns200:kestrel
Closed

ClientCertificateMode now read from config#18759
kuns200 wants to merge 1 commit into
dotnet:masterfrom
kuns200:kestrel

Conversation

@kuns200
Copy link
Copy Markdown
Contributor

@kuns200 kuns200 commented Feb 3, 2020

Client certificate mode can now be read from config file.
It uses, connectionreader.cs
Addresses #18660

@ghost ghost added the area-servers label Feb 3, 2020
@guardrex guardrex mentioned this pull request Feb 6, 2020
Merged
halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Core/src/Internal/ConfigurationReader.cs
private IList<EndpointConfig> _endpoints;
private EndpointDefaults _endpointDefaults;

private string _clientCertificateMode;
Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this type ClientCertificateMode?

halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Core/src/Internal/ConfigurationReader.cs
}
}


Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove the extra newline above and below property.

halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Core/src/Internal/ConfigurationReader.cs
}
}

private void ReadClientCertificateMode()
Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do the enum parsing instead of LoadClientCertificateMode in KestrelConfigurationLoader.

Copy link
Copy Markdown
Member

@Tratcher Tratcher Feb 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare to ParseProtocols

halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Core/src/Internal/ConfigurationReader.cs
private void ReadClientCertificateMode()
{
_clientCertificateMode = _configuration[ClientCertificateModeKey];
}
Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Core/src/Internal/ConfigurationReader.cs

private static HttpProtocols? ParseProtocols(string protocols)
private static HttpProtocols? ParseProtocols(string protocols)
Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo this.

halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Kestrel/test/ConfigurationReaderTests.cs
{
public class ConfigurationReaderTests
{

Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Kestrel/test/ConfigurationReaderTests.cs
var reader = new ConfigurationReader(config);
var clientCertificateMode = reader.ClientCertificateMode;
Assert.NotNull(clientCertificateMode);
}
Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

halter73
halter73 reviewed Feb 7, 2020
View reviewed changes
Comment thread src/Servers/Kestrel/Kestrel/test/ConfigurationReaderTests.cs
var reader = new ConfigurationReader(config);
var clientCertificateMode = reader.ClientCertificateMode;
Assert.Null(clientCertificateMode);
}
Copy link
Copy Markdown
Member

@halter73 halter73 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Feb 11, 2020
@kuns200
Copy link
Copy Markdown
Contributor Author

kuns200 commented Feb 12, 2020

ok . will make changes.

@halter73
Copy link
Copy Markdown
Member

halter73 commented Feb 24, 2020

@kuns200 Do you have time to look at this again? Thanks.

@shirhatti
Copy link
Copy Markdown
Contributor

shirhatti commented Apr 10, 2020

@kuns200 Are you still interested in doing this?

@halter73 halter73 self-assigned this Apr 15, 2020
@BrennanConroy
Copy link
Copy Markdown
Member

BrennanConroy commented May 15, 2020

@kuns200 If you're still interested you can open a new PR

@kuns200
Copy link
Copy Markdown
Contributor Author

kuns200 commented May 5, 2021

I was busy last year with few things at home. Can I look this now? Or is it done?

@ghost
Copy link
Copy Markdown

ghost commented May 5, 2021

Hi @kuns200. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@BrennanConroy
Copy link
Copy Markdown
Member

BrennanConroy commented May 5, 2021

Looks like it got done via #24076

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 left review comments

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@halter73 halter73

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

5.0.0-preview6

Development

Successfully merging this pull request may close these issues.

8 participants

@kuns200 @halter73 @shirhatti @BrennanConroy @Tratcher @analogrelay @pranavkm @amcasey