A quick collection of quick fixes#20993
Merged
Merged
Conversation
Contributor
Author
|
Additional verification builds
|
dougbu
force-pushed
the
dougbu/quick.fixes
branch
2 times, most recently
from
3c4a685 to
8ee921f
Compare
Pilchie
added
the
area-infrastructure
dougbu
force-pushed
the
dougbu/quick.fixes
branch
3 times, most recently
from
eaea3ec to
b0f4606
Compare
dougbu
requested review from
Tratcher,
analogrelay,
halter73 and
jkotalik
as code owners
Contributor
Author
|
Oops, missing a commit and I forgot to rerun some validation builds. Back to draft… |
wtgodbe
approved these changes
Apr 21, 2020
dougbu
force-pushed
the
dougbu/quick.fixes
branch
from
b0f4606 to
1102190
Compare
dougbu
commented
Apr 22, 2020
| steps: | ||
| - script: git submodule init | ||
| - script: git submodule update --recursive | ||
| - script: cd ./src/Components |
Contributor
Author
There was a problem hiding this comment.
@mkArtakMSFT you may want to look at this file in particular
Contributor
There was a problem hiding this comment.
Looks fine to me. I initially have totally forgotten that this is something I had created. Thanks @pranavkm for reminding this 👍
Anyway, the change looks reasonable. We should discuss in our next meeting whether this is still useful. We tend to look at the official CI views rather than this any more, so maybe it's time to completely stop this.
| @@ -1,4 +1,6 @@ | |||
| <Project> | |||
| <Import Project="eng\Common.props" /> | |||
Contributor
Author
There was a problem hiding this comment.
Without this, $(BuildNative) was only available in the projects that needed it when property was global
| @ECHO OFF | ||
| SET RepoRoot=%~dp0..\.. | ||
|
|
||
| ECHO Building Microsoft.AspNetCore.Runtime.SiteExtension |
Contributor
Author
|
Marking this as ready to review though validation builds (all but devBuilds.yml one) are failing due to what appear to be general infrastructure issues |
- remove an excess build step
- quote all rooted paths - check `%ERRORLEVEL%` after every `CALL` - nits: - add a few more `ECHO` commands - wrap long lines
…ers.beforeBuild` - ensure NuGet.config is ready for all internal builds - remove now-duplicate `SetupNugetSources` invocations wherever default-build.yml is used
- fix problems using `-all` or `/p:BuildAllProjects=true` without `-buildNative` - ensure `$(BuildNative)` is `false` where it's not supported - move some duplicated settings into eng/Common.props and `<Import />` the new file - remove now-duplicated parts of conditions using `$(BuildNative)`
- remove need to specify `/p:BuildAllProjects=true` - nit: simplify some Boolean logic
- avoid `/p:Build*` on the command line (except with eng/scripts/ci-source-build.sh) - nits: - remove now-useless `-buildNative` with `-all` - expand and correct a couple of related comments and messages
dougbu
force-pushed
the
dougbu/quick.fixes
branch
from
1102190 to
bc8ab4e
Compare
Contributor
Author
|
🆙📅 to pick up latest from 'master'. @mkArtakMSFT and @JunTaoLuo please weigh in. |
mkArtakMSFT
approved these changes
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetupNugetSourcesscript invocations aboveparameters.beforeBuild$(BuildNative)is always set correctly-alltogether with-projects--build-*(Mostly found while working on #20748. Some parts will make it easier to use
dotnetmore if we continue down that road.)