Log type of ObjectResult in ObjectResultExecutor#21425
Merged
Merged
Conversation
ghost
added
the
area-mvc
rynowak
reviewed
May 3, 2020
rynowak
reviewed
May 3, 2020
rynowak
requested changes
May 3, 2020
Member
rynowak
left a comment
rynowak
left a comment
There was a problem hiding this comment.
Thanks for doing this, this looks like the right idea, there are a few small changes I want to see.
Contributor
Author
|
I re-pushed the same commit because the last checks ran out of memory and it didn't seem like a problem with the commit. We will see. |
rynowak
approved these changes
May 7, 2020
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Addresses #21393