Fix Windows 7 Kestrel tests#23069
Merged
Merged
Conversation
JunTaoLuo
commented
Jun 18, 2020
| displayName: Restore interop projects | ||
| - script: ./build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildNative -projects eng\helix\helix.proj | ||
| /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true | ||
| /p:IsHelixDaily=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true |
Contributor
Author
There was a problem hiding this comment.
Revert before merging.
halter73
reviewed
Jun 18, 2020
halter73
approved these changes
Jun 18, 2020
Contributor
Author
|
I'm seeing some errors on Win7 It also seems like my changes in #22859 broke quite a few tests on Windows 8. Not sure why those weren't caught when I ran the tests in that PR. I'll fix those up. |
added 3 commits
June 18, 2020 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how these tests were missed in the previous iteration #22918.