-
Notifications
You must be signed in to change notification settings - Fork 10.7k
ElementReference FocusAsync API #23316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
292bff6
Added working focus extension method.
MackinnonBuck d0d1fa6
Merge branch 'master' into t-mabuc/element-focus
MackinnonBuck 5b211e9
Added return value documentation for FocusAsync().
MackinnonBuck a6b136e
Removed IJSRuntime argument from FocusAsync().
MackinnonBuck 067e4b1
Removed ElementReference.JSRuntime in favor of IServiceProvider.
MackinnonBuck 9b14eba
Updated Web.JS release binaries.
MackinnonBuck d8102d0
Implemented ElementReferenceContext.
MackinnonBuck 64b6b02
Merge branch 'master' into t-mabuc/element-focus
MackinnonBuck 8332cdf
Made ElementReferenceContext a non-abstract property in Renderer.
MackinnonBuck 9d29a23
Made ElementReference.Context explicitly nullable.
MackinnonBuck c6038d7
Removed useless IServiceProvider dependency in RemoteJSRuntime.
MackinnonBuck 9e69f12
Updated Microsoft.AspNetCore.Components reference assemblies.
MackinnonBuck 93a7dfe
Improved documentation and limited public API.
MackinnonBuck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| namespace Microsoft.AspNetCore.Components | ||
| { | ||
| /// <summary> | ||
| /// Context for an <see cref="ElementReference"/>. | ||
| /// </summary> | ||
| public abstract class ElementReferenceContext | ||
| { | ||
| } | ||
| } | ||
2 changes: 1 addition & 1 deletion
2
src/Components/Components/src/Microsoft.AspNetCore.Components.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import '@microsoft/dotnet-js-interop'; | ||
|
|
||
| export const domFunctions = { | ||
| focus, | ||
| }; | ||
|
|
||
| function focus(element: HTMLElement): void { | ||
| if (element instanceof HTMLElement) { | ||
| element.focus(); | ||
| } else { | ||
| throw new Error('Unable to focus an invalid element.'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| namespace Microsoft.AspNetCore.Components | ||
| { | ||
| internal static class DomWrapperInterop | ||
| { | ||
| private const string Prefix = "Blazor._internal.domWrapper."; | ||
|
|
||
| public const string Focus = Prefix + "focus"; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.JSInterop; | ||
|
|
||
| namespace Microsoft.AspNetCore.Components | ||
| { | ||
| public static class ElementReferenceExtensions | ||
| { | ||
| /// <summary> | ||
| /// Gives focus to an element given its <see cref="ElementReference"/>. | ||
| /// </summary> | ||
| /// <param name="elementReference">A reference to the element to focus.</param> | ||
| /// <returns>The <see cref="ValueTask"/> representing the asynchronous focus operation.</returns> | ||
| public static ValueTask FocusAsync(this ElementReference elementReference) | ||
| { | ||
| var jsRuntime = elementReference.GetJSRuntime(); | ||
|
|
||
| if (jsRuntime == null) | ||
| { | ||
| throw new InvalidOperationException("No JavaScript runtime found."); | ||
| } | ||
|
|
||
| return jsRuntime.InvokeVoidAsync(DomWrapperInterop.Focus, elementReference); | ||
| } | ||
|
|
||
| internal static IJSRuntime GetJSRuntime(this ElementReference elementReference) | ||
| { | ||
| if (!(elementReference.Context is WebElementReferenceContext context)) | ||
| { | ||
| throw new InvalidOperationException("ElementReference has not been configured correctly."); | ||
| } | ||
|
|
||
| return context.JSRuntime; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.