Use new string.Split() overloads#23683
Merged
Tratcher merged 2 commits intodotnet:masterfrom Jul 5, 2020
Merged
Conversation
Use new Split() overloads to remove need to allocate arrays.
Use static array for new line chars instead of allocating a new one each time.
Tratcher
approved these changes
Jul 5, 2020
Member
|
Thanks |
Member
|
Related: You should also take a look at dotnet/runtime#35740 and GrabYourPitchforks@bbf393f if you're trying to clean up these code paths a bit. |
Member
Author
|
Ah nice, I wasn't aware of that incoming. Looks like one of these changes could be refactored to use the new enum member. |
Member
Author
|
Ah wait, I noticed you already did it in the referenced commit 😃 |
Member
|
Yup. Feel free to send a new PR and improve upon it however you see fit. |
Member
Author
Done - #23712 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string.Split()overloads to remove need to allocate arrays.HtmlEncodeAndReplaceLineBreaks()instead of allocating a new one each time.