Skip to content

Use HasFlag in ForwardedheadersMiddleware#24660

Merged
1 commit merged into
dotnet:masterfrom
Kahbazi:kahbazi/HasFlag
Aug 8, 2020
Merged

Use HasFlag in ForwardedheadersMiddleware#24660
1 commit merged into
dotnet:masterfrom
Kahbazi:kahbazi/HasFlag

Conversation

@Kahbazi
Copy link
Copy Markdown
Member

@Kahbazi Kahbazi commented Aug 7, 2020

No description provided.

@ghost ghost added the area-middleware label Aug 7, 2020
@Kahbazi Kahbazi marked this pull request as ready for review August 7, 2020 15:42
@Kahbazi Kahbazi requested a review from Tratcher as a code owner August 7, 2020 15:42
@halter73
Copy link
Copy Markdown
Member

halter73 commented Aug 7, 2020

I'll let @Tratcher decide if we should merge this, but the performance of HasFlag is not as bad as it used to be on full framework: dotnet/coreclr#13748

@ghost
Copy link
Copy Markdown

ghost commented Aug 8, 2020

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d0a8117 into dotnet:master Aug 8, 2020
@Kahbazi Kahbazi deleted the kahbazi/HasFlag branch August 8, 2020 04:26
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants