Merged PR 9371: Revive support for globalization and localization in Blazor WASM by pranavkm · Pull Request #24773 · dotnet/aspnetcore

pranavkm · 2020-08-11T04:48:26Z

Manually porting preview8 changes to master

Revive support for globalization and localization in Blazor WASM

Load icu and timezone data files
Unskip tests

captainsafia · 2020-08-11T05:07:00Z

    /* type */ 'dotnetwasm');

-  const dotnetTimeZoneResourceName = 'dotnet.timezones.dat';
+  const dotnetTimeZoneResourceName = 'dotnet.timezones.blat';


Is this a typo or a legit file format?

I've heard Larry talk about this so I guess it's the name of the archive file format. Apparently it's like a tar file.

captainsafia · 2020-08-11T05:10:29Z

+    let timeZone = "UTC";
+    try {
+      timeZone = Intl.DateTimeFormat().resolvedOptions().timeZone;
+    } catch { }


Why is it OK to ignore errors thrown here?

captainsafia · 2020-08-11T05:11:43Z

            var runtime = bootJsonData.resources.runtime.Keys;
            Assert.Contains("dotnet.wasm", runtime);
-            Assert.DoesNotContain("dotnet.timezones.dat", runtime);
+            Assert.DoesNotContain("dotnet.timezones.blat", runtime);


Ah -- OK. So the blat file extension is intentional...

captainsafia · 2020-08-11T05:12:16Z

            for (var i = 0; i < assemblies.Length; i++)
            {
-                Assembly.Load((byte[])assemblies[i]);
+                using var stream = new MemoryStream((byte[])assemblies[i]);


SteveSandersonMS

Seems like this is mostly porting pre-existing changes so approving. Looks good anyway.

pranavkm · 2020-08-11T18:01:18Z

@lewing I'm seeing issues with non-en cultures. Here's the stack trace:

_abort@dotnet.5.0.0-rc.1.20371.13.js:1
ves_icall_System_Environment_FailFast@00aba79e:1
ves_icall_System_Environment_FailFast_raw@00aba79e:1
do_icall@00aba79e:1
do_icall_wrapper@00aba79e:1
interp_exec_method@00aba79e:1
interp_runtime_invoke@00aba79e:1
mono_jit_runtime_invoke@00aba79e:1
do_runtime_invoke@00aba79e:1
mono_runtime_try_invoke@00aba79e:1
mono_runtime_try_invoke_handle@00aba79e:1
invoke_resolve_method@00aba79e:1
mono_alc_invoke_resolve_using_resolve_satellite@00aba79e:1
mono_alc_invoke_resolve_using_resolve_satellite_nofail@00aba79e:1
netcore_load_reference@00aba79e:1
mono_assembly_request_byname@00aba79e:1
ves_icall_System_Reflection_Assembly_InternalLoad@00aba79e:1
ves_icall_System_Reflection_Assembly_InternalLoad_raw@00aba79e:1
do_icall@00aba79e:1
do_icall_wrapper@00aba79e:1
interp_exec_method@00aba79e:1
interp_runtime_invoke@00aba79e:1
mono_jit_runtime_invoke@00aba79e:1
do_runtime_invoke@00aba79e:1
mono_runtime_try_invoke@00aba79e:1
mono_runtime_try_invoke_handle@00aba79e:1
invoke_resolve_method@00aba79e:1
mono_alc_invoke_resolve_using_resolve_satellite@00aba79e:1

Could you help?

CoffeeFlux · 2020-08-12T21:33:44Z

I'll take a look; getting this set up locally.

CoffeeFlux · 2020-08-13T02:04:45Z

Finally got a repro working, looking into this now.

CoffeeFlux · 2020-08-14T19:48:49Z

Building locally with the linker disabled and swapping out SPC for one built with dotnet/runtime#40817 seems to fix this locally, so hopefully once that change flows down to this repo we'll be good to go. 😄

benaadams · 2020-08-15T06:12:41Z

ooof

…Blazor WASM Revive support for globalization and localization in Blazor WASM * Load icu and timezone data files * Unskip tests Fixes #24174 Fixes #22975 Fixes #23260

ghost · 2020-08-17T19:47:59Z

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

pranavkm · 2020-08-17T20:04:34Z

@benaadams we're looking at sharding the icu file, which should make the default compressed size about half of the numbers being reported here. There's also an option to enable invariant mode if you do not require this data that should eliminate this file entirely.

pranavkm requested review from a team and SteveSandersonMS as code owners August 11, 2020 04:48

pranavkm added the area-blazor Includes: Blazor, Razor Components label Aug 11, 2020

captainsafia reviewed Aug 11, 2020

View reviewed changes

captainsafia approved these changes Aug 11, 2020

View reviewed changes

SteveSandersonMS approved these changes Aug 11, 2020

View reviewed changes

pranavkm force-pushed the prkrishn/revive-globalization branch from c3df503 to 3818ef0 Compare August 11, 2020 18:00

pranavkm added the blocked The work on this issue is blocked due to some dependency label Aug 11, 2020

pranavkm added this to the 5.0.0-rc1 milestone Aug 11, 2020

CoffeeFlux mentioned this pull request Aug 14, 2020

Handle potential null in ALC.ResolveSatelliteAssembly dotnet/runtime#40817

Merged

Merged PR 9371: Revive support for globalization and localization in …

4e57d1b

…Blazor WASM Revive support for globalization and localization in Blazor WASM * Load icu and timezone data files * Unskip tests Fixes #24174 Fixes #22975 Fixes #23260

pranavkm force-pushed the prkrishn/revive-globalization branch from 3818ef0 to 4e57d1b Compare August 17, 2020 16:02

Fixups

8a8a1ac

pranavkm added auto-merge and removed blocked The work on this issue is blocked due to some dependency labels Aug 17, 2020

pranavkm changed the base branch from master to release/5.0 August 17, 2020 21:24

pranavkm merged commit 2ad1b6d into release/5.0 Aug 18, 2020

pranavkm deleted the prkrishn/revive-globalization branch August 18, 2020 13:33

Conversation

pranavkm commented Aug 11, 2020

Uh oh!

captainsafia Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

SteveSandersonMS Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

captainsafia Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

captainsafia Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

captainsafia Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

SteveSandersonMS left a comment

Choose a reason for hiding this comment

Uh oh!

pranavkm commented Aug 11, 2020

Uh oh!

CoffeeFlux commented Aug 12, 2020

Uh oh!

CoffeeFlux commented Aug 13, 2020

Uh oh!

CoffeeFlux commented Aug 14, 2020

Uh oh!

benaadams commented Aug 15, 2020

Uh oh!

ghost commented Aug 17, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

pranavkm commented Aug 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.