Enable test logging for ProjectTemplate tests#26507
Merged
Merged
Conversation
Pilchie
approved these changes
Oct 1, 2020
Member
Author
If I get general consensus that this is a good change/correct way to do it, then I can update the other tests and move it |
Member
Author
|
I didn't add LoggedTest to Components and BlazorTemplates as they have other complex infrastructure that I am unfamiliar with. But I did get rid of the Xunit.TestFramework that they were using and moved them to the common one we use everywhere else. |
2d4f326 to
cfbb362
Compare
Member
Author
|
Any feedback? |
Member
|
So the new logs are these ones? |
Member
Author
|
Yep, they didn't exist before. |
Tratcher
approved these changes
Oct 7, 2020
Member
Author
|
@dotnet/aspnet-build please merge when available! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible change to templates tests so we have log artifacts. Only applied it to a couple tests to show the idea first.