[SignalR] Remove obsolete APIs#28100
Merged
Merged
Conversation
halter73
approved these changes
Nov 25, 2020
Member
halter73
left a comment
There was a problem hiding this comment.
Normally, I would say why break it? But since this basically just changes a NotSupportedException to a MethodMissingException for libraries, and it makes what could be an annoying runtime error into a compile-time error for projects that are rebuilding anyway, this makes a lot of sense.
|
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #27529
Both APIs already throw when used. The
ParseResponsemethod was obsoleted in 3.1,HubInvocationContext.ctorwas obsoleted in 5.0.I have seen no evidence of anyone using
HubInvocationContext.ctorand there wasn't a good reason to use it before 5.0 (Hub filters).I have seen one place using
ParseResponse, but the newest version of the package uses the non-obsolete method.