Clean up obsolete APIs in MVC#28337
Merged
1 commit merged intoDec 25, 2020
Merged
Conversation
|
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
captainsafia
commented
Dec 3, 2020
pranavkm
reviewed
Dec 3, 2020
pranavkm
reviewed
Dec 14, 2020
Contributor
Author
|
@dotnet/aspnet-api-review This is good for review. I've removed references to |
2070b3c to
6c1d1ec
Compare
6c1d1ec to
0c18367
Compare
pranavkm
approved these changes
Dec 25, 2020
|
Hello @pranavkm! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #27529.
Summary of Changes
MVCOptionswas removed since that will eventually trigger a null-ref in the code.Remove GetFileStream API inPhysicalFileResultExecutorandVirtualFileResultExecutorbecause codepath is no-longer invoked.AllowShortCircuitingValidationWhenNoValidatorsArePresentin ValidationVisitor because value no-ops and has been obsolete since 3.0.RemoveRazorViewAttributeandRazorPageAttributeand instances of use since they are deprecated in favor of newer APIs.ViewComponentResultExecutorwhich set a nullWriterFactorysince the value was overridden anyways.CompatabilityVersiontype.