Use source generators to compile Razor files#28807
Closed
pranavkm wants to merge 1 commit into
Closed
Conversation
507be65 to
544efd1
Compare
544efd1 to
0874ea6
Compare
| { | ||
| var path = item.Path; | ||
| var isComponent = path.EndsWith(".razor", StringComparison.OrdinalIgnoreCase); | ||
| var isRazorView = !isComponent && path.EndsWith(".cshtml", StringComparison.OrdinalIgnoreCase); |
There was a problem hiding this comment.
"!isComponent" is redundant check now. if path.EndsWith(".cshtml", StringComparison.OrdinalIgnoreCase) == true then path.EndsWith(".razor", StringComparison.OrdinalIgnoreCase) = false.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the use of
RazorGenerateandRazorTagHelpertasks, and rzc, with a source generator that discovers tag helpers, code generates .razor and .cshtml files, and compiles the .razor files. .cshtml files are written to disk that are used during .Views.dll compilation.Some notes:
Open issues: