Removing CancelableAsyncEnumerable#32090
Merged
Merged
Conversation
ghost
added
area-signalr
Contributor
Author
|
@BrennanConroy and @halter73 may I get a review? |
halter73
reviewed
Apr 27, 2021
ladeak
force-pushed
the
ladeak_7960
branch
3 times, most recently
from
deadace to
1ce2bdd
Compare
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
halter73
reviewed
May 11, 2021
…erator DefaultHubDispatcher iterates using the enumerator Adding a tests
halter73
reviewed
May 12, 2021
halter73
approved these changes
May 12, 2021
Member
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
LGTM pending adding the /Shared/ .ConfigureAwait(false) back. Thanks!!
Contributor
Author
|
Thank you for the update. I am seeing that the Linux-ARM64 build is failing with It seems this is some tooling issue. I would like to re-run builds (or at least that build) but I don't see a button for that. Is there a way to do that (other than pushing an update to the branch)? |
BrennanConroy
approved these changes
May 13, 2021
Member
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
Excellent! Thanks for doing this!
Member
|
Thanks again @ladeak ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing CancelableAsyncEnumerable
Using a while loop as discussed in a PR discussion previously: #6791 (comment)
Description
Addresses #7960