Skip to content

Make Razor.slnf buildable from command-line#32141

Merged
Pilchie merged 1 commit intodotnet:mainfrom
KirillOsenkov:dev/kirillo/slnf
Apr 25, 2021
Merged

Make Razor.slnf buildable from command-line#32141
Pilchie merged 1 commit intodotnet:mainfrom
KirillOsenkov:dev/kirillo/slnf

Conversation

@KirillOsenkov
Copy link
Copy Markdown
Member

With the comma building Razor.slnf from command-line results in error:

Solution file error MSB5025: Json in solution filter file "C:\AspNetCore\src\Razor\razor.slnf" is incorrectly formatted.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 24, 2021
@KirillOsenkov KirillOsenkov changed the title Dev/kirillo/slnf Make Razor.slnf buildable from command-line Apr 24, 2021
@KirillOsenkov KirillOsenkov requested a review from Pilchie April 24, 2021 23:46
With the comma building Razor.slnf from command-line results in error:

Solution file error MSB5025: Json in solution filter file "C:\AspNetCore\src\Razor\razor.slnf" is incorrectly formatted.
@Pilchie Pilchie requested a review from a team April 25, 2021 03:29
@Pilchie
Copy link
Copy Markdown
Member

Pilchie commented Apr 25, 2021

Ugh, seems like we should try to make MSBuild and VS have the same level of resiliency - @rainersigwald

@Pilchie Pilchie merged commit af98102 into dotnet:main Apr 25, 2021
@ghost ghost added this to the 6.0-preview5 milestone Apr 25, 2021
@KirillOsenkov KirillOsenkov deleted the dev/kirillo/slnf branch April 25, 2021 04:55
@KirillOsenkov
Copy link
Copy Markdown
Member Author

I filed dotnet/msbuild#6371

@ghost
Copy link
Copy Markdown

ghost commented Apr 25, 2021

Hi @KirillOsenkov. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@rainersigwald
Copy link
Copy Markdown
Member

Great news! dotnet/msbuild#6346 fixed this for 16.10/5.0.300.

@ghost
Copy link
Copy Markdown

ghost commented Apr 26, 2021

Hi @rainersigwald. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@Pilchie
Copy link
Copy Markdown
Member

Pilchie commented Apr 26, 2021

Awesome, thanks @rainersigwald !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants