Fix web root for WebApplication#32604
Conversation
|
|
||
| using System.Runtime.CompilerServices; | ||
|
|
||
| [assembly: InternalsVisibleTo("Microsoft.AspNetCore.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100f33a29044fa9d740c9b3213a93e57c84b472c84e0b8a0e1ae48e67a9f8f6de9d5f7f3d52ac23e48ac51801f1dc950abe901da34d2a9e3baadb141a17c77ef3c565dd5ee5054b91cf63bb3c6ab83f72ab3aafe93d0fc3c2348b764fafb0b1c0733de51459aeab46580384bf9d74c4e28164b7cde247f891ba07891c9d872ad2bb")] |
There was a problem hiding this comment.
Don't we have a better way to do this from the csproj now?
|
@SteveSandersonMS @javiercn @captainsafia @pranavkm the blazor performance tests are broken |
|
|
||
| namespace Microsoft.AspNetCore.Tests | ||
| { | ||
| public class WebHostEnvironmentTests |
There was a problem hiding this comment.
Is there a test making sure static files works?
| var app = WebApplication.Create(args); | ||
|
|
||
| webApp.MapGet("/", (Func<string>)(() => "Hello, World!")); | ||
| app.UseStaticFiles(); |
There was a problem hiding this comment.
I guess you manually tested this?
There was a problem hiding this comment.
Yes. I can write a manual automated test. There aren't any e2e tests in DefaultBuilder that don't hit the network stack so I was a little lazy and just went with the unit tests and the sample.
Can you clarify which ones? The WebAssembly benchmarks still seem to be working fine. And do you mean they are broken already, or just after this PR? The build on CI doesn't seem to indicate that this PR breaks any perf tests. |
|
It’s the razor compiler issue with generic constraints. |
Is it being fixed? Can these tests be skipped? Is it flaky? We want to merge this PR 😄 |
|
Yes, it was quarantined yesterday by @captainsafia: #32593 |
|
/azp run aspnetcore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
added this to the
|
🥳 |
|
Hi @DamianEdwards. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
amcasey
added
area-minimal
6 participants
Fixes #32415