enable nullable for new projects

[jmarolf]

resolves dotnet/templates#485

[mkArtakMSFT]

@danroth27 can you please confirm that we want to take this change in for our templates? Thanks!

[pranavkm]

I would love to enable nullability, but I think we would enable it by default rather than make it a switch that a user has to choose. That said, I think there are some important pieces we would need to address before we did that:

• Nullability for identity UI so that it scaffolds well
• Update scaffolding for controllers / ef /razor
• Fix some Razor code generation bugs where it inadvertently suppresses nullability in user code.

The remainder of the framework is annotated enough (and we will cover more by 6.0) that users should find the experience productive.

[jmarolf]

@pranavkm should this be closed or is there some set of projects we think its appropriate for?

[danroth27]

I would love to enable nullability, but I think we would enable it by default rather than make it a switch that a user has to choose.

👍

I think there are some important pieces we would need to address before we did that:

Do we have tracking issues for these remaining work items?

[jmarolf]

I would love to enable nullability, but I think we would enable it by default rather than make it a switch that a user has to choose.

it is enabled by default. The defaultValue is true. The user needs to explicitly pass false

[captainsafia]

@danroth27 There's #32783

[danroth27]

@jmarolf I think the question is do we need a switch at all. Once we are at a place with ASP.NET Core that we can turn on nullability checks by default, is there really a need for users to have a switch to turn it off?

[jmarolf]

I think the question is do we need a switch at all

I have no objections. I added the switch as a conservative measure. If we are comfortable just using this as the default that makes things simpler.

[davidfowl]

this looks kinda terrible.

[DamianEdwards]

Nullable was enabled by the other changes that went in today.