Fix WebApplicationBuilder to read environment specific config for logging#32822
Closed
halter73 wants to merge 10 commits into
Closed
Fix WebApplicationBuilder to read environment specific config for logging#32822halter73 wants to merge 10 commits into
halter73 wants to merge 10 commits into
Conversation
halter73
force-pushed
the
halter73/32383
branch
3 times, most recently
from
f3d8942 to
693b4c2
Compare
halter73
commented
May 18, 2021
| var bootstrapBuilder = new BootstrapHostBuilder(Configuration, _environment); | ||
| bootstrapBuilder.ConfigureDefaults(args); | ||
| bootstrapBuilder.ConfigureWebHostDefaults(configure: _ => { }); | ||
| bootstrapBuilder.ConfigureDefaults(args); |
Member
Author
There was a problem hiding this comment.
Flipping the order of configuring WebHostDefaults was important for ensuring that the right appsettings.{Env}.json gets loaded initially when ASPNETCORE_ENVIRONMENT is configured. I don't know of any negative consequences of flipping the default configuration order for the BootstrapHostBuilder, but that doesn't mean there aren't any.
This was referenced May 21, 2021
Closed
amcasey
added
area-minimal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
CreateDefaultBuilder/ConfigureWebHostDefaults
Fixes #32383
Thanks to @KevinCathcart for dotnet/runtime#51770 (comment)
TODO: Add tests