Update IdentityServer4 -> Duende#33590
Conversation
| <Reference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" /> | ||
| <Reference Include="Microsoft.AspNetCore.Identity.UI" /> | ||
| <Reference Include="Newtonsoft.Json" /> | ||
| <SuppressBaselineReference Include="IdentityServer4.AspNetIdentity" /> |
There was a problem hiding this comment.
@aspnet-build is this something I should be checking in (SupressBaselineReference?)
There was a problem hiding this comment.
It's alright if the pseudo-breaking change is approved. I'm a bit more concerned about having a shipping package depend on an unsigned assembly. Thoughts @Pilchie❔
There was a problem hiding this comment.
This would be my only concern as well. I couldn't find other instances of shipping projects doing this in our repo or dotnet/runtime
There was a problem hiding this comment.
@blowdart seems to be okay with this, is there anyone else we should ping about this? To clarify its signed, but doesn't have a strong name, poor choice in wording by me
There was a problem hiding this comment.
Our Nuget package is signed. The assemblies do not have a strong name. What would be the benefit of that for a library targeting .NET Core consumers only?
HaoK
changed the title
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Also, why are you adding the empty src/Identity/ApiAuthorization.IdentityServer/src/ApiAuthorizationDbContext.cs file❔
| <Reference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" /> | ||
| <Reference Include="Microsoft.AspNetCore.Identity.UI" /> | ||
| <Reference Include="Newtonsoft.Json" /> | ||
| <SuppressBaselineReference Include="IdentityServer4.AspNetIdentity" /> |
There was a problem hiding this comment.
It's alright if the pseudo-breaking change is approved. I'm a bit more concerned about having a shipping package depend on an unsigned assembly. Thoughts @Pilchie❔
| /// <value> | ||
| /// The keys. | ||
| /// </value> | ||
| public DbSet<Key> Keys { get; set; } |
There was a problem hiding this comment.
I see a couple of new DbSet<T> properties in this PR but haven't noticed new references to them. What are they for❔
There was a problem hiding this comment.
Yeah it comes from a new requirement from the updated version of IPersistedGrantDbContext, which now store Keys, I'm not sure exactly what they are used for, but its part of the contract for IdentityServer Stores
|
Which one is the unsigned package @dougbu mentions? |
|
@blowdart all of the identity server packages are unsigned, by design it appears: DuendeArchive/IdentityServer4#1653 |
|
Oh strong named rather than signed. Yea not worried then considering it has no security benefits, and it's "only" a dependency rather than shipping as part of the product. |
ghost
added this to the
9 participants
Fixes #32881