Update SDK version

[BrennanConroy]

Part of build ops

[dougbu]

Could you quickly summarize why these lines in the installer need to change❔ For example has a bare dotnet new command been deprecated at the same time the output format changed❔

[BrennanConroy]

For example has a bare dotnet new command been deprecated at the same time the output format changed❔

No clue, I'm testing to see if that's the case by using --list.

The first part with checking commas is because dotnet new now displays all "short names" for the template. Might be able to clean it up a bit, but again, doing exploratory testing here.

[dougbu]

Huh. I don't remember a breaking change notification but the output might not be something we should really rely on. @KathleenDollard who should we loop in here❔

[BrennanConroy]

Looks like --list worked, now just failing on some restore issues.

[BrennanConroy]

Old dotnet new output would list all templates it looks like, new dotnet new lists a predetermined list of "common templates".

Looks like a very deliberate change, so I think our reaction to add --list is fine.

[BrennanConroy]

I think the ors I added can be removed now that --list is used

[sebastienros]

I don't think so, I checked and it was displaying templates the way your are testing them. For me the --list would just display a new prompt, and then the same table as before without the --list.

[sebastienros]

Build is failing on mac and linux while restoring nuget packages for two tests:

[xUnit.net 00:05:13.78]     Templates.Test.EmptyWebTemplateTest.EmptyWebTemplateCSharp [FAIL]

 | [11.662s] Templates.Test.EmptyWebTemplateTest Information: The template "ASP.NET Core Empty" was created successfully.
 | [11.673s] Templates.Test.EmptyWebTemplateTest Information: 
 | [11.673s] Templates.Test.EmptyWebTemplateTest Information: Processing post-creation actions...
 | [11.674s] Templates.Test.EmptyWebTemplateTest Information: Running 'dotnet restore' on /datadisks/disk1/work/9C2008E7/w/9F50091A/e/Templates/BaseFolder/AspNet.4jel0wrqdam/AspNet.4jel0wrqdam.csproj...
 | [311.903s] Templates.Test.EmptyWebTemplateTest Information: [ERROR] Restore failed.

[xUnit.net 00:11:59.26]     Templates.Test.WebApiTemplateTest.WebApiTemplateCSharp_IdentityWeb_BuildsAndPublishes(auth: "SingleOrg", args: null) [FAIL]

 | [27.729s] Templates.Test.WebApiTemplateTest Information: The template "ASP.NET Core Web API" was created successfully.
 | [27.729s] Templates.Test.WebApiTemplateTest Information: 
 | [27.729s] Templates.Test.WebApiTemplateTest Information: Processing post-creation actions...
 | [27.730s] Templates.Test.WebApiTemplateTest Information: Running 'dotnet restore' on /datadisks/disk1/work/9C2008E7/w/9F50091A/e/Templates/BaseFolder/AspNet.kthak30aajf/AspNet.kthak30aajf.csproj...
 | [328.501s] Templates.Test.WebApiTemplateTest Information: [ERROR] Restore failed.

It looks like restore is interrupted after 5 minutes, but there is no log about the reason.

The SDK code that executes this step is

https://github.com/dotnet/templating/blob/main/src/Microsoft.TemplateEngine.Cli/PostActionProcessors/DotnetRestorePostActionProcessor.cs#L92-L93

When run locally, the ProjectTemplates tests seem blocked, so the CI might actually have some sort of timeout that interrupts them.

[dougbu]

It looks like restore is interrupted after 5 minutes, but there is no log about the reason.

Not sure where 5 minutes comes from.

The most common timeout in template tests is 15 minutes for various dotnet processes. See ProcessEx changes in #32889 for something that changes that value. There's also a ProcessLock class used to wait for process completion. The wait defaults to 20 minutes and is never overridden.

In addition, the dotnet test command run in Helix jobs (see

aspnetcore/eng/helix/content/RunTests/TestRunner.cs

Line 218 in 46ef939

var commonTestArgs = $"test {Options.Target} --diag:{diagLog} --logger:xunit --logger:\"console;verbosity=normal\" --blame \"CollectHangDump;TestTimeout=15m\"";

) specifies a fifteen minute test timeout (for dump collection). In addition,

aspnetcore/eng/helix/content/RunTests/TestRunner.cs

Lines 215 to 216 in 46ef939

	// Timeout test run 5 minutes before the Helix job would timeout
	var cts = new CancellationTokenSource(Options.Timeout.Subtract(TimeSpan.FromMinutes(5)));

times tests out five minutes before the Helix job times out. The default Helix timeout is 30 minutes, 40 on Windows (see

aspnetcore/eng/targets/Helix.props

Lines 14 to 15 in 0551cef

	<HelixTimeout>00:30:00</HelixTimeout>
	<HelixTimeout Condition="$(HelixTargetQueue.StartsWith('Windows.10.Amd64'))">00:40:00</HelixTimeout>

).

[sebastienros]

I think it's a timeout in dotnet restore itself, or in the test runner, I can repro the same time locally when running a single test.

[sebastienros]

Actually found the timeout in ProcessEx https://github.com/dotnet/aspnetcore/blob/main/src/Shared/Process/ProcessEx.cs#L31

This could mean that dotnet restore is taking more than 5 minutes and the ProcessEx class is killing it.