Separate IResult based results from ActionResults by pranavkm · Pull Request #33843 · dotnet/aspnetcore

pranavkm · 2021-06-25T14:28:57Z

davidfowl · 2021-06-25T14:33:15Z

Why a new assembly?

pranavkm · 2021-06-25T14:42:29Z

The results depend on M.A.Routing which adds a circular dependency if they are in M.A.H.Extensions.

davidfowl · 2021-06-25T15:03:06Z

+
+        public Task ExecuteAsync(HttpContext httpContext)
+        {
+            var loggerFactory = httpContext.RequestServices.GetRequiredService<ILoggerFactory>();


We're going to want to cache these calls to the logger, but that should be in another PR. My guess is that we haven't looked at this cost in MVC.

davidfowl · 2021-06-25T15:04:58Z

-        private static Action<ILogger, StringValues, string, Exception?> _copyingFileRange;
-        private static Action<ILogger, Exception?> _writeCancelled;
-        private static Action<ILogger, Exception?> _endpointMatched;
+        private static readonly Action<ILogger, string, Exception?> _methodNotSupported;


Source generator?

It's this analyzer - which is a suggestion, but shows up as warnings in VS: https://github.com/dotnet/aspnetcore/blob/main/.editorconfig#L100-L101. Source generator to happen separately.

DamianEdwards · 2021-06-25T15:54:30Z

+        /// <summary>
+        /// Creates a <see cref="ChallengeResult"/>.
+        /// </summary>
+        /// <returns>The created <see cref="ChallengeResult"/> for the response.</returns>


Is it OK to refer to internal types in these public doc comments? What happens when API doc is generated?

The API docs will referer to the type full name, and completion colorizes it correctly, but you're not able to control click on the type to get there. Not super weird. I didn't change the doc comments much as I mas transferring them from MVC, but if you feel strongly about it, I can do a pass to clean it up.

DamianEdwards · 2021-06-25T16:28:19Z

+        /// Creates a <see cref="AcceptedResult"/> object that produces an <see cref="StatusCodes.Status202Accepted"/> response.
+        /// </summary>
+        /// <param name="uri">The optional URI with the location at which the status of requested content can be monitored.
+        /// May be null.</param>


We're not consistent with how we document nullable ref types in params. Some are 'blah blah; may be null', others are like this one. Let's just pick one form and stick with it.

DamianEdwards · 2021-06-25T16:29:15Z

+        /// <summary>
+        /// Creates a <see cref="AcceptedResult"/> object that produces an <see cref="StatusCodes.Status202Accepted"/> response.
+        /// </summary>
+        /// <param name="value">The optional content value to format in the entity body; may be null.</param>


Might 'response body' be clearer language than 'entity body'?

Sure. I think this comment might have been from WebAPI2 which tends to use the RFC names

DamianEdwards · 2021-06-25T16:49:43Z

+            string contentType,
+            string? fileDownloadName,
+            bool enableRangeProcessing)
+            => new PhysicalFileResult(physicalPath, contentType)


Curious, why is this one expression bodied but the next one not?

Somebody forgot to update MVC: https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Core/src/ControllerBase.cs#L1647-L1677

davidfowl · 2021-06-27T01:31:21Z

@pranavkm can you make one of the samples use these?

dougbu · 2021-06-27T01:55:37Z

Curious: I skimmed the projects but couldn't find a reference to the new project. Other than the samples @davidfowl suggested, where will the assembly be used❔

pranavkm · 2021-06-28T18:56:03Z

@dougbu the plan is to use these in the minimal actions project template. I updated a functional test to use some of these result types.

Co-authored-by: Martin Costello <martin@martincostello.com>

davidfowl reviewed Jun 25, 2021

View reviewed changes

DamianEdwards reviewed Jun 25, 2021

View reviewed changes

Pilchie added the area-runtime label Jun 25, 2021

pranavkm force-pushed the prkrishn/results branch 3 times, most recently from 803688f to 025962d Compare June 26, 2021 19:23

pranavkm marked this pull request as ready for review June 26, 2021 19:23

pranavkm requested review from a team, BrennanConroy, Pilchie, Tratcher and javiercn as code owners June 26, 2021 19:23

Separate IResult based results from ActionResults

7d22183

pranavkm force-pushed the prkrishn/results branch from 025962d to 7d22183 Compare June 26, 2021 19:24

ilkayilknur mentioned this pull request Jun 28, 2021

Add IResult implementations for more IActionResults #32565

Closed

12 tasks

martincostello reviewed Jun 28, 2021

View reviewed changes

Comment thread src/Http/Http.Results/src/PhyiscalFileResult.cs

pranavkm added 3 commits June 28, 2021 10:22

Add some functional tests

9f27fc6

Fixups

53204a0

Fix typo

a5f07c0

martincostello reviewed Jun 28, 2021

View reviewed changes

Comment thread src/Http/Http.Results/src/ChallengeResult.cs Outdated

Comment thread src/Http/Http.Results/src/PhysicalFileResult.cs Outdated

Comment thread src/Http/Http.Results/src/AcceptedAtRouteResult.cs Outdated

Comment thread src/Http/Http.Results/src/AcceptedAtRouteResult.cs Outdated

pranavkm and others added 2 commits June 28, 2021 13:45

Apply suggestions from code review

85fc7cb

Co-authored-by: Martin Costello <martin@martincostello.com>

Clean up docs

b330b73

pranavkm force-pushed the prkrishn/results branch from 3244ce7 to b330b73 Compare June 28, 2021 23:55

Merge branch 'main' into prkrishn/results

67cf9ae

halter73 approved these changes Jun 30, 2021

View reviewed changes

pranavkm enabled auto-merge (squash) June 30, 2021 16:59

pranavkm merged commit b9efadc into main Jun 30, 2021

pranavkm deleted the prkrishn/results branch June 30, 2021 17:32

ghost added this to the 6.0-preview7 milestone Jun 30, 2021

halter73 mentioned this pull request Dec 8, 2021

Make IResult methods more testable #37502

Closed

amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023

Conversation

pranavkm commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidfowl commented Jun 25, 2021

Uh oh!

pranavkm commented Jun 25, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidfowl commented Jun 27, 2021

Uh oh!

dougbu commented Jun 27, 2021

Uh oh!

Uh oh!

pranavkm commented Jun 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pranavkm commented Jun 25, 2021 •

edited

Loading