Skip to content

Add support for enhanced line pragmas#33954

Merged
captainsafia merged 3 commits into
mainfrom
safia/line-pragmas
Jul 7, 2021
Merged

Add support for enhanced line pragmas#33954
captainsafia merged 3 commits into
mainfrom
safia/line-pragmas

Conversation

@captainsafia
Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 30, 2021
@captainsafia captainsafia force-pushed the safia/line-pragmas branch 6 times, most recently from d589a0c to 5d4ebde Compare July 6, 2021 19:34
@captainsafia captainsafia marked this pull request as ready for review July 6, 2021 22:20
@captainsafia captainsafia requested review from NTaylorMullen and tmat and removed request for Pilchie, dougbu and javiercn July 6, 2021 22:20
Comment thread eng/Versions.props Outdated
Comment thread src/Analyzers/Analyzers/src/StartupAnalyzer.Diagnostics.cs Outdated
Copy link
Copy Markdown
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need something for cshtml files too?

Comment thread src/Mvc/Mvc.Api.Analyzers/src/ApiDiagnosticDescriptors.cs
Copy link
Copy Markdown
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. The plan is to add support for cshtml files in a follow up.

@captainsafia captainsafia enabled auto-merge (squash) July 7, 2021 21:12
@captainsafia captainsafia merged commit 96cc622 into main Jul 7, 2021
@captainsafia captainsafia deleted the safia/line-pragmas branch July 7, 2021 21:40
@ghost ghost added this to the 6.0-preview7 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants