Fix SignalR TS unit tests not running on CI#35422
Merged
Merged
Conversation
BrennanConroy
added
area-signalr
wtgodbe
approved these changes
Aug 17, 2021
BrennanConroy
force-pushed
the
brecon/tstest
branch
from
e639e9a to
0af0ad4
Compare
davidfowl
approved these changes
Aug 18, 2021
Member
Author
|
/backport to release/6.0-rc1 |
Contributor
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1143982719 |
ghost
added this to the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken by #32510 which moved the
<IsTestProject>property above the import. So added a comment to help us remember not to move it.Also noticed that when we updated jest-junit earlier this year it had a breaking change in how it output test result files, so fixed that so it's picked up by the CI correctly.